[Macros] Code item macros #64765
Merged
[Macros] Code item macros #64765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
requested review from
hborla,
xedin,
slavapestov,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
rintaro and
zoecarver
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
rxwei
commented
Apr 4, 2023
Comment on lines
+1347
to
+1354
| if (auto *substituteDecl = E->getSubstituteDecl()) { | ||
| if (doIt(substituteDecl)) | ||
| return nullptr; | ||
| // Visiting the substitute macro expansion decl will visit the same | ||
| // argument list. Skip visiting it again. | ||
| shouldWalkArguments = false; | ||
| } | ||
|
|
There was a problem hiding this comment.
@DougGregor Because a MacroExpansionExpr and its substitute decl are sharing the argument list again after 1ba7c14, this became necessary to prevent the argument list from being visited twice. Otherwise it triggers an assertion failure in VarDeclUsageChecker.
There was a problem hiding this comment.
This localized suppression of visiting the argument list makes sense to me, thanks for pointing it out.
|
@swift-ci please smoke test |
bnbarham
reviewed
Apr 4, 2023
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
@swift-ci please smoke test |
Add support for declaring and expanding code item macros. Add experimental feature flag `CodeItemMacros`.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for declaring and expanding code item macros.
rdar://106326121