SIL Parser: Use a Set instead of a Vector for zombie functions to avoid duplicates #6478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
Do we iterate over this? If so, it might be better to use a SetVector, to be sure it's deterministic. |
|
@jrose-apple We only iterate over it during destruction, to set all functions as zombies basically, we do not need need determinism |
|
Swift CI is down unfortunately, can't merge into master even though this is quite the blocker for our builds / tests :( |
|
Linux failure is unrelated. Merging. |
|
I meant OS X failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had duplicate function definitions in SIL, those got inserted more than once into the potentially zombie functions vector, causing a crash / duplicate work on them. This caused a bug in SIL/Parser/array_roundtrip.swift
This PR changes the data structure to a Set to avoid duplications
Fixes
rdar://problem/29780448
rdar://problem/29767444