[CSApply] Teach coerceCallArguments about variadic generics
#64780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is important if overload is variadic generic, in such cases substitution map is used to determine actual parameter index.
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
For variadic generic declarations we need to compute a substituted
version of bindings because all of the packs are exploded in the
substituted function type.
```swift
func fn<each T>(_: repeat each T) {}
fn("", 42)
```
The type of `fn` in the call is `(String, Int) -> Void` but bindings
have only one parameter at index `0` with two argument positions: 0, 1.
…w pack expansions `coerceCallArguments` has to be `ParameterList::getOrigParamIndex` to determine "original" parameter version which could be used with un-substituted parameter list.
xedin
force-pushed
the
fix-default-args-with-variadic-generics
branch
from
484a9df to
00fbdc7
Compare
|
@swift-ci please test |
hborla
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For variadic generic declarations we need to compute a substituted
version of bindings because all of the packs are exploded in the
substituted function type.
The type of
fnin the call is(String, Int) -> Voidbut bindingshave only one parameter at index
0with two argument positions: 0, 1.