[Serialization] Attempt to load transitive implementation-only dependencies on testable imports #64783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please Test Source Compatibility Debug |
elsh
reviewed
Mar 30, 2023
elsh
reviewed
Mar 30, 2023
| @@ -1702,7 +1702,7 @@ ModuleFileSharedCore::getTransitiveLoadingBehavior( | |||
| if (dependency.isImplementationOnly()) { | |||
| // Implementation-only dependencies are not usually loaded from | |||
| // transitive imports. | |||
| if (debuggerMode) { | |||
| if (debuggerMode || forTestable) { | |||
elsh
approved these changes
Mar 30, 2023
…testable imports Implementation-only dependencies may be referenced from internal decls. When that module is imported as @testable, clients see the internal decls and may fail accessing them if the transitive implementation-only dependencies are not loaded. Let's consider such transtive implementation-only dependencies as optional for @testable imports. As such, the compiler will attempt to load them for test targets, and won't fail if the dependency is missing. We can make these dependencies required for non-public imports, but it could be project breaking to do so for implementation-only dependencies. Considering them as optional is a decent compromise. rdar://79459263
xymus
force-pushed
the
impl-only-testable2
branch
from
44bda35 to
4327c73
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation-only dependencies may be referenced from internal decls. When that module is imported as
@testable, clients see the internal decls and may fail accessing them if the transitive implementation-only dependencies are not loaded.Let's consider such transitive implementation-only dependencies as optional for
@testableclients. As such, the compiler will attempt to load them for test targets, and won't fail if the dependency is missing.We can make these dependencies required for non-public imports, but it could be project breaking to do so for implementation-only dependencies. Considering them as optional is a decent compromise.
rdar://79459263