-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[5.9] Introduce -unavailable-decl-optimization
#64810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tshortli
merged 10 commits into
swiftlang:release/5.9
from
tshortli:unavailable-decl-optimization-5.9
Mar 31, 2023
Merged
[5.9] Introduce -unavailable-decl-optimization
#64810
tshortli
merged 10 commits into
swiftlang:release/5.9
from
tshortli:unavailable-decl-optimization-5.9
Mar 31, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of rdar://106674022
Avoid SIL lowering for declarations marked unavailable when `-unavailable-decl-optimiation=complete` is specified. Part of rdar://106674022
This ensures SIL lowering will avoid generating code for unavailable global vars when `-unavailable-decl-optimization=complete` is specfied. Part of rdar://106674022
Part of rdar://106674022
Part of rdar://107425181
Part of rdar://107425181
c7c0fde
to
5e1fcbc
Compare
@swift-ci please test |
@swift-ci please test Windows |
nkcsgexi
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new mode is behind a flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #64644 and #64808
Introduce the
-unavailable-decl-optimization
frontend flag which can be used to reduce the size of a compiled binary by removing machine code related to declarations that are marked unavailable with an@available
attribute. Unavailable code is meant to be provably unreachable at runtime for a specific execution context and therefore including machine code for these declarations is wasteful.In this iteration, the flag supports two modes:
none
: Does not remove any code related to unavailable declarations. This is the default.complete
: Avoids generating any machine code for unavailable declarations. This will be the most aggressive optimization available.The plan is to expand the available modes in the future with at least one more option,
stub
, which will cause unavailable functions to be emitted as stubs containing justfatalError()
. This option will be needed by owners of resilient libraries to preserve ABI compatibility since existing clients may link against the symbols for unavailable declarations, even if they never execute them.Resolves rdar://106674022 and rdar://107425181