Skip to content

[5.9][Dependency Scanning] Disable Swift Parser ASTGen during dependency scan #64830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Mar 31, 2023

On both input moduel source-files and interface files. This currently yields dramatic scanning performance improvements at no cost - we do not require an AST during scan.

On both input moduel source-files and interface files.
This currently yields dramatic scanning performance improvements at no cost - we do not require an AST during scan.
@artemcm artemcm requested review from nkcsgexi and ahoppen March 31, 2023 22:59
@artemcm artemcm requested a review from a team as a code owner March 31, 2023 22:59
@artemcm
Copy link
Contributor Author

artemcm commented Mar 31, 2023

@swift-ci test

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great finding👍

@artemcm
Copy link
Contributor Author

artemcm commented Apr 3, 2023

@swift-ci test macOS platform

@artemcm artemcm merged commit 665ef46 into swiftlang:release/5.9 Apr 3, 2023
@artemcm artemcm deleted the 59DisableASTGenParseInDepScan branch April 3, 2023 21:08
@AnthonyLatsis AnthonyLatsis added the 🍒 release cherry pick Flag: Release branch cherry picks label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants