[Mem2Reg] Fix store_borrow user block omission. #64834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when blocks were added to the worklist, only blocks which were users of the `alloc_stack` instruction were considered. For "guaranteed alloc_stacks" (`store_borrow` locations), that resulted in not processing blocks which contained uses of the `store_borrow` but not the `alloc_stack`. When such a user was an `end_borrow`, the effect was that no `end_borrow` was created for the newly introduced `begin_borrow [lexical]`. Fix this by adding blocks with users of the `store_borrow` to the worklist.
|
@swift-ci please test |
|
@swift-ci please test macos platform |
1 similar comment
|
@swift-ci please test macos platform |
|
@nate-chandler Do we need a similar change for load_borrows as well ? |
|
No, for the same reason that we don't need to visit all uses of regular |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when blocks were added to the worklist, only blocks which were users of the
alloc_stackinstruction were considered. For "guaranteed alloc_stacks" (store_borrowlocations), that resulted in not processing blocks which contained uses of thestore_borrowbut not thealloc_stack. When such a user was anend_borrow, the effect was that noend_borrowwas created for the newly introducedbegin_borrow [lexical].Fix this by adding blocks with users of the
store_borrowto the worklist.