Fix lookup into macros that can introduce members into types and extensions #64840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When populating the name lookup tables for a nominal type, we were only visiting declarations with peer macros within the nominal type declaration itself. Also visit the members of extensions of the nominal type. Without this change, peer-macro-defined members of extensions are not visible.
…isible. Ensure that name lookup triggers the expansion of member macros on extensions, so we can find those names. And fix a bug that caused expansion of member macros to crash.
…kup. Rather than eagerly expanding all member macros when doing any name lookup into a type, use the same introduced-name-tracking logic we apply to peer macros to only expand those member macros that can produce the requested name. This makes the compiler lazier.
When populating the name lookup tables with macro-expanded declarations, we were careful to avoid full macro resolution for attached macros, but freestanding macros were will doing full resolution. Switch freestanding macros over to the same partial resolution mechanism to avoid reference cycles.
|
@swift-ci please smoke test |
rxwei
approved these changes
Apr 1, 2023
Some lookups, such as the ones used for protocol conformance checking, provide full names (with arguments). Drop everything down to simple names so they we don't skip macro expansions when we might need them.
|
The Observation failure was a useful one; I've now fixed an issue with compound names dodging macro expansions. |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix and improve lookup for macro-introduced members within types and their extensions:
Fixes rdar://107530389