[cxx-interop] Make sure interop does not trigger TBD validation errors #64841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please test |
egorzhdan
force-pushed
the
egorzhdan/cxx-tbd-validation
branch
from
9406511 to
43161fd
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
I think that's fine, but we should be mindful that it's not necessarily a fix, rather a workaround. We do have additional issues tracking this here: |
hyp
reviewed
Apr 4, 2023
| @@ -410,6 +411,14 @@ void ArgsToFrontendOptionsConverter::computeTBDOptions() { | |||
| Diags.diagnose(SourceLoc(), diag::error_unsupported_option_argument, | |||
| A->getOption().getPrefixedName(), value); | |||
| } | |||
| } else if (Args.hasArg(OPT_enable_experimental_cxx_interop) || | |||
| Args.hasArg(OPT_cxx_interoperability_mode)) { | |||
| // TBD validation currently emits erroneous diagnostics when C++ interop is | |||
There was a problem hiding this comment.
I would argue that the diagnostics are not erroneous, but rather that IRGen is incorrectly applying linkage and/or visibility to the symbols. I think we need to clarify in the comment that this is specifically a workaround for correct diagnostics, and that it also must be a FIXME.
There was a problem hiding this comment.
Thanks, that makes sense, I updated the comment.
egorzhdan
force-pushed
the
egorzhdan/cxx-tbd-validation
branch
from
43161fd to
50910da
Compare
This disables TBD validation when C++ interop is enabled, unless an explicit `-validate-tbd-against-ir=` flag was passed. rdar://83405989 / #56458
egorzhdan
force-pushed
the
egorzhdan/cxx-tbd-validation
branch
from
50910da to
8f58eaf
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://83405989 / #56458