Improved Cast Diagnostics when Literals are involved #64846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AnthonyLatsis Request your review. |
Rajveer100
force-pushed
the
branch-for-issue-53822
branch
from
2bd2566 to
7d69a5c
Compare
|
@swift-ci please smoke test macOS |
|
Please let me know more issues to solve! While I keep surfing and searching, often there are issues which are not marked as 'good-first-issues' but I assume I can at least try some viable ones! |
|
We have to update the test cases for this new message as well =] |
|
Whoops! My bad! |
Rajveer100
force-pushed
the
branch-for-issue-53822
branch
from
7d69a5c to
f745115
Compare
|
@swift-ci please smoke test macOS |
|
@swift-ci Please smoke test macOS platform |
Rajveer100
force-pushed
the
branch-for-issue-53822
branch
from
f745115 to
c87f451
Compare
|
Any other additions/changes that's required? |
Rajveer100
force-pushed
the
branch-for-issue-53822
branch
from
c87f451 to
60a9f47
Compare
|
@AnthonyLatsis I have made the changes... |
AnthonyLatsis
approved these changes
Apr 6, 2023
Rajveer100
force-pushed
the
branch-for-issue-53822
branch
from
60a9f47 to
2c96e90
Compare
|
Thanks! I have done that too! |
|
@swift-ci please smoke test macOS |
|
@swift-ci please test Linux platform |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53822
Emphasised the diagnostic involving conditional downcast to coercion making it more specific adding some contrast between casting (
as?) and coercing (as).