Skip to content

Add -restore to msbuild call for Windows installer #64860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Apr 3, 2023

Backport the changes to the Windows build script to enable us to migrate to WiX 4.0 which is required for proper handling of version information in the installer. This also allows us to enable the ARM64 packaging and more importantly migrate away from the (now) deprecated WiX 3.x series.

@compnerd compnerd requested a review from a team as a code owner April 3, 2023 14:20
@compnerd
Copy link
Member Author

compnerd commented Apr 3, 2023

Please test with following PRs:
swiftlang/swift-installer-scripts#186

@swift-ci please build toolchain Windows platform

@compnerd
Copy link
Member Author

compnerd commented Apr 3, 2023

Please test with following PRs:
swiftlang/swift-installer-scripts#186

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Apr 3, 2023

CC: @airspeedswift

@compnerd compnerd merged commit 8301a02 into swiftlang:release/5.9 Apr 4, 2023
@compnerd compnerd deleted the 59-40 branch April 4, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants