Skip to content

[5.9] add AST printer support for _documentation attribute #64869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2023
Merged

[5.9] add AST printer support for _documentation attribute #64869

merged 1 commit into from
Apr 14, 2023

Conversation

QuietMisdreavus
Copy link
Contributor

@QuietMisdreavus QuietMisdreavus commented Apr 3, 2023 •
edited by AnthonyLatsis
Loading

Cherry-pick of #64326

  • Explanation: Use of the @_documentation attribute crashes symbolkit-lsp, because it lacks an AST printer implementation. This PR adds support for printing @_documentation attributes via the AST printer to prevent sourcekit-lsp from crashing.
  • Scope: Allows SourceKit to be used with projects that have adopted the @_documentation attribute.
  • Issue: Resolves (lib/IDE) @_documentation attribute always crashes sourcekit-lsp #64309, rdar://106657906
  • Risk: Low. Ordinary compilation should not be affected.
  • Testing: An automated test has been added to ensure that SourceKit doesn't crash. Existing automated tests still pass.
  • Reviewer: @ahoppen, @xedin, @bnbarham

@QuietMisdreavus QuietMisdreavus requested a review from a team as a code owner April 3, 2023 18:08
@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus QuietMisdreavus merged commit cd43e05 into release/5.9 Apr 14, 2023
@QuietMisdreavus QuietMisdreavus deleted the QuietMisdreavus/5.9/doc-attr-sourcekit branch April 14, 2023 21:08
@AnthonyLatsis AnthonyLatsis added the 🍒 release cherry pick Flag: Release branch cherry picks label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airspeedswift airspeedswift airspeedswift approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuietMisdreavus @airspeedswift @AnthonyLatsis