Sema: Ban unavailable stored properties #64885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
force-pushed
the
ban-unavailable-stored-properties
branch
from
4beefef to
d6bd513
Compare
Preparation for rdar://107449845
Marking a stored property as unavailable with `@available` should be banned, just like it already is banned for potential unavailability. Unavailable code is not supposed be reachable at runtime, but unavailable properties with storage create a back door into executing arbitrary unavailable code at runtime: ``` @available(*, unavailable) struct Unavailable { init() { print("Unavailable.init()") } } struct S { @available(*, unavailable) var x = Unavailable() } _ = S() // prints "Unavailable.init()" ``` Resolves rdar://107449845
tshortli
force-pushed
the
ban-unavailable-stored-properties
branch
from
d6bd513 to
9812c90
Compare
|
@swift-ci please test |
|
@swift-ci please clean test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking a stored property as unavailable with
@availableshould be banned, just like it already is banned for potential unavailability. Unavailable code is not supposed be reachable at runtime, but unavailable properties with storage create a back door into executing arbitrary unavailable code at runtime:Resolves rdar://107449845