[ASTScope] Adjust parent location for peer macro to after its attached decl. #64892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d decl. Peer macro produce declarations that are semantically alongside the declaration to which the macro is attached. However, the source location used for constructing the scope tree was based on the attribute itself, which meant it was inside the scope of the declaration to which the macro was attached. This lead to incorrect unqualified name lookup; in the example that's now a test case, this meant that the `Self` of the protocol to which the macro was attached was visible from within the peer declaration. Hilarity (in the form of a type checker crash) ensued. Fix the location used for constructing the scope tree of peer macros to be right after the attached declaration. Fixes rdar://107228586.
|
@swift-ci please smoke test |
rxwei
approved these changes
Apr 4, 2023
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peer macro produce declarations that are semantically alongside the declaration to which the macro is attached. However, the source location used for constructing the scope tree was based on the attribute itself, which meant it was inside the scope of the declaration to which the macro was attached. This lead to incorrect unqualified name lookup; in the example that's now a test case, this meant that the
Selfof the protocol to which the macro was attached was visible from within the peer declaration. Hilarity (in the form of a type checker crash) ensued.Fix the location used for constructing the scope tree of peer macros to be right after the attached declaration. Fixes rdar://107228586.