[CSSimplify] Prevent invalid pack references from causing infinite loops #64907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `matchTypesBindTypeVar` detects invalid pack reference it should reset the type to a placeholder and allow binding to go through, otherwise, if binding comes from inference, returning without binding would create an infinite loop because type variable would perpetually be the best choice to attempt.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
matchTypesBindTypeVardetects invalid pack referenceit should reset the type to a placeholder and allow binding to go
through, otherwise, if binding comes from inference, returning
without binding would create an infinite loop because type variable
would perpetually be the best choice to attempt.