[5.9] Always specify -gmodules on built-in Clang invocations
#64913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
nkcsgexi
approved these changes
Apr 4, 2023
|
Great findings! |
This is currently always done when instantiating `ClangImporter` by manually setting the option on the Clang invocation with: ``` Invocation->getCodeGenOpts().DebugTypeExtRefs = true ``` Now also add it to `importer::addCommonInvocationArguments` so that the dependency scanner always generates command-lines with the required for Swift Clang flags. Resolves rdar://107570568
artemcm
force-pushed
the
59AlwaysClangDepScanGModules
branch
from
7019643 to
a51ea60
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #64912
This is currently always done when instantiating
ClangImporterby manually setting the option on the Clang invocation with:Now also add it to
importer::addCommonInvocationArgumentsso that the dependency scanner always generates command-lines with the required for Swift Clang flags.Resolves rdar://107570568