[5.9] [move-only] Temporarily ban deinits on non-copyable enums. #64919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason why we are doing this is that: 1. For non-copyable types, switches are always at +1 for now. 2. non-copyable enums with deinits cannot be switched upon since that would invalidate the deinit. So deinits on non-copyable enums are just not useful at this point since you cannot open the enum. Once we make it so that you can bind a non-copyable enum at +0, we will remove this check. I added an experimental feature MoveOnlyEnumDeinits so tests that validate the codegen/etc will still work. rdar://101651138
|
@swift-ci Please test |
tbkka
approved these changes
Apr 4, 2023
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason why we are doing this is that:
So deinits on non-copyable enums are just not useful at this point since you cannot open the enum.
Once we make it so that you can bind a non-copyable enum at +0, we will remove this check.
I added an experimental feature MoveOnlyEnumDeinits so tests that validate the codegen/etc will still work.
rdar://101651138