Skip to content

Document which registers are used for the async context on x86-64/ARM64. #64947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2023
Merged

Document which registers are used for the async context on x86-64/ARM64. #64947

merged 1 commit into from
Apr 6, 2023

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Apr 5, 2023

This change updates the calling convention documentation to document which registers are used for the async context on x86-64/ARM64.

@grynspan
Copy link
Contributor Author

grynspan commented Apr 5, 2023

@swift-ci please smoke test

@MaxDesiatov
Copy link
Contributor

@swift-ci smoke test macos

al45tair
al45tair approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@al45tair al45tair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (and you've saved me a [very small] job; I was going to make that change when I had a spare moment).

@al45tair
Copy link
Contributor

al45tair commented Apr 6, 2023

@swift-ci Please smoke test macOS platform

@grynspan grynspan merged commit 22150c5 into main Apr 6, 2023
@grynspan grynspan deleted the jgrynspan/document-async-context-register branch April 6, 2023 15:23
@grynspan
Copy link
Contributor Author

grynspan commented Apr 6, 2023

Welp, my reply to @al45tair ended up as the commit message… yay.

grynspan added a commit that referenced this pull request Apr 6, 2023
@grynspan
Revert "Document which registers are used for the async context on x8…
427875b 
…6-64/ARM64. (#64947)"

This reverts commit 22150c5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@al45tair al45tair al45tair approved these changes

@mikeash mikeash Awaiting requested review from mikeash

@rjmccall rjmccall Awaiting requested review from rjmccall rjmccall is a code owner

@airspeedswift airspeedswift Awaiting requested review from airspeedswift

@aschwaighofer aschwaighofer Awaiting requested review from aschwaighofer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grynspan @MaxDesiatov @al45tair