Skip to content

Emit cxx interop into DW_AT_APPLE_flags #64958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

augusto2112
Copy link
Contributor

@augusto2112 augusto2112 commented Apr 5, 2023

When compiling with interop enabled, emit the C++ interop compiler flag into the DW_AT_APPLE_flags, to make it so LLDB can accurately match the C++ interop mode when initializing its compiler.

rdar://97610458


Cherry pick of #65069.

@augusto2112
Copy link
Contributor Author

@swift-ci smoke test

@augusto2112
Copy link
Contributor Author

@swift-ci test

@augusto2112 augusto2112 marked this pull request as ready for review April 10, 2023 17:45
@augusto2112 augusto2112 requested a review from a team as a code owner April 10, 2023 17:45
Copy link
Contributor

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for it that checks the DICompileUnit int the -emit-ir output?

@augusto2112 augusto2112 force-pushed the interop-debug-flags branch from 71ec4db to 4a7137c Compare April 10, 2023 21:13
@augusto2112
Copy link
Contributor Author

@swift-ci test

When compiling with interop enabled, emit the C++ interop compiler flag
into the DW_AT_APPLE_flags, to make it so LLDB can accurately match the
C++ interop mode when initializing its compiler instance.

rdar://97610458
@augusto2112 augusto2112 force-pushed the interop-debug-flags branch from 4a7137c to b1dbb0a Compare April 10, 2023 22:47
@augusto2112
Copy link
Contributor Author

@swift-ci test

@augusto2112 augusto2112 merged commit 6c54fef into swiftlang:release/5.9 Apr 11, 2023
@AnthonyLatsis AnthonyLatsis added the 🍒 release cherry pick Flag: Release branch cherry picks label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants