Skip to content

[5.9] Sema: Only diagnose unavailable attr when it is active for the target #64962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented Apr 5, 2023

Cherry-pick of #64961.

An attribute may be "active" but also not the most specific attribute for the current target and therefore ignored.

Resolves rdar://107678512

@tshortli tshortli requested a review from nkcsgexi April 5, 2023 23:58
@tshortli tshortli requested a review from a team as a code owner April 5, 2023 23:58
@tshortli
Copy link
Contributor Author

tshortli commented Apr 5, 2023

@swift-ci please test

@tshortli tshortli added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.9 labels Apr 5, 2023
@tshortli tshortli changed the title Sema: Only diagnose unavailable attr when it is active for the target [5.9] Sema: Only diagnose unavailable attr when it is active for the target Apr 6, 2023
An attribute may be "active" but also not the most specific attribute for the
current target and therefore ignored.

Resolves rdar://107678512
@tshortli tshortli force-pushed the unavailable-property-with-storage-diagnostic-maccatalyst-5.9 branch from bda8814 to 10e639e Compare April 6, 2023 04:51
@tshortli
Copy link
Contributor Author

tshortli commented Apr 6, 2023

@swift-ci please test

@tshortli tshortli merged commit 9d4a19d into swiftlang:release/5.9 Apr 6, 2023
@tshortli tshortli deleted the unavailable-property-with-storage-diagnostic-maccatalyst-5.9 branch April 6, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants