[TypeLowering] Fixed verifier variable shadowing. #64971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To work around a build failure on MSVC, f53e88b changed what was stored in the verifier’s worklist from a `TaggedEnum<ValueDecl *, unsigned>` to two fields `ValueDecl *` and `Optional<unsigned>` with the idea that only one should ever be non-none. That change failed, however, to return the _optional_ unsigned index represented by the value in the worklist, instead returning the actual value. That’s a problem because the worklist can’t contain `Optional<unsigned>` but only unsigned with `UINT_MAX` indicating "none". rdar://107709069
|
@swift-ci please test |
atrick
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To work around a build failure on MSVC, f53e88b changed what was vended from the verifier’s worklist from a
TaggedEnum<ValueDecl *, unsigned>to two fieldsValueDecl *andOptional<unsigned>with the idea that only one should ever be non-none. That change failed, however, to return the optional unsigned index represented by the value in the worklist, instead returning the actual value. That’s a problem because the worklist can’t containOptional<unsigned>but only unsigned withUINT_MAXindicating "none".rdar://107709069