[Completion] Only provide macro completions when they are valid #64986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
force-pushed
the
macro-completion
branch
from
58afce1 to
2d77803
Compare
|
@swift-ci please test |
rintaro
reviewed
Apr 6, 2023
|
Ah that's annoying, warning/error are macros on MacOS but not on Linux/Windows (for obvious reasons). |
bnbarham
force-pushed
the
macro-completion
branch
from
2d77803 to
fbd91b0
Compare
ahoppen
reviewed
Apr 7, 2023
bnbarham
force-pushed
the
macro-completion
branch
2 times, most recently
from
584cc87 to
921b40d
Compare
|
@swift-ci please test |
ahoppen
approved these changes
Apr 7, 2023
Only return macros that are valid in their current position, ie. an attached macro is not valid on a nominal. Also return freestanding expression macros in code block item position and handle the new freestanding code item macros. Resolves rdar://105563583.
bnbarham
force-pushed
the
macro-completion
branch
from
921b40d to
31dee1c
Compare
|
@swift-ci please test |
bnbarham
commented
Apr 8, 2023
| @@ -1130,6 +1130,8 @@ static void addPoundDirectives(CodeCompletionResultSink &Sink) { | |||
| Builder.addSimpleTypedParameter("Int"); | |||
| Builder.addRightParen(); | |||
| }); | |||
|
|
|||
| #ifndef SWIFT_SWIFT_PARSER | |||
There was a problem hiding this comment.
I had originally removed this, but better to keep it for linux/windows for now. We can remove after SWIFT_SWIFT_PARSER is enabled in all the places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only return macros that are valid in their current position, ie. an attached macro is not valid on a nominal.
Also return freestanding expression macros in code block item position and handle the new freestanding code item macros.
Resolves rdar://105563583.