Skip to content

[Concurrency] Rename Job to ExecutorJob, ease transition with typealias #65006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 11, 2023
Merged

[Concurrency] Rename Job to ExecutorJob, ease transition with typealias #65006

merged 3 commits into from
Apr 11, 2023

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Apr 7, 2023

According to SE review, we want to not take over the Job name.

This attempts to first introduce a typealias, and then we could maybe remove Job entirely.

Looking for input if this strategy makes sense.

@ktoso
Copy link
Contributor Author

ktoso commented Apr 7, 2023

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Apr 7, 2023

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please clean test with toolchain and preset

@ktoso
Copy link
Contributor Author

ktoso commented Apr 10, 2023

ExecutorJob/Job need to be handled manually in the "only one of overloads can be implemented" because of how we provide default impls for both. Glad that the tests caught that nicely.

Added the special handling in tryDiagnoseExecutorConformance if we get to remove Job we can undo the last commit from here

@ktoso ktoso requested a review from DougGregor April 10, 2023 09:14
@ktoso
Copy link
Contributor Author

ktoso commented Apr 10, 2023

@swift-ci please smoke test

@ktoso ktoso changed the title rename Job type [Concurrency] Rename Job to ExecutorJob, ease transition with typealias Apr 10, 2023
@ktoso ktoso mentioned this pull request Apr 10, 2023
Merged
@ktoso
Copy link
Contributor Author

ktoso commented Apr 10, 2023

@swift-ci please clean smoke test macos

@ktoso
Copy link
Contributor Author

ktoso commented Apr 10, 2023

Renaming job sadly overlapped with adding a test which used job type in message... re-running with adjustment.

@ktoso
Copy link
Contributor Author

ktoso commented Apr 10, 2023

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Apr 11, 2023

Our good ol' random failure friend:

macos.swiftinterface:4:8: error: no such module 'Combine'
import Combine
^

@ktoso
Copy link
Contributor Author

ktoso commented Apr 11, 2023

@swift-ci please smoke test macos

@ktoso ktoso merged commit 80b9386 into swiftlang:main Apr 11, 2023
@ktoso ktoso deleted the wip-rename-job branch April 11, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@DougGregor DougGregor Awaiting requested review from DougGregor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ktoso