[5.9][IRGen] Prevent overflow in RecordField with large explosions #65018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://99415586 Exploding very large types could cause an overflow, which in turn caused a crash later in IRGen. Fixed by increasing width of the variables in question from 16 to 32 bit and adding an overflow check.
drexin
changed the title
|
@swift-ci test |
|
@tbkka The PR to main was reviewed and approved by @aschwaighofer. Would you mind approving this? |
tbkka
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from: #64828
rdar://99415586
Exploding very large types could cause an overflow, which in turn caused a crash later in IRGen. Fixed by increasing width of the variables in question from 16 to 32 bit and adding an overflow check.