[interop] make interop diagnostics more consistent with the rest of S… #65043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyp
requested review from
zoecarver,
egorzhdan,
hborla,
slavapestov and
xedin
as code owners
hyp
requested review from
ravikandhadai
and removed request for
xedin,
slavapestov and
hborla
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
zoecarver
reviewed
Apr 10, 2023
| NOTE(record_is_dependent, none, "record '%0' is dependent", (StringRef)) | ||
| NOTE(record_parent_unimportable, none, "record %0's parent is not importable", (StringRef)) | ||
| NOTE(reference_passed_by_value, none, "function uses foreign reference type " | ||
| "'%0' as a value in %1 types which breaks " | ||
| "'swift_shared_reference' contract (outlined in " | ||
| "C++ Interop User Manual).", | ||
| "the C++ interoperability user manual)", |
There was a problem hiding this comment.
Is this something we really want to be pointing people at?
There was a problem hiding this comment.
We should remove this reference to User manual. This would become stale once we have documentation elsewhere.
zoecarver
approved these changes
Apr 10, 2023
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…wift diagnostics