[swift][AutoLinkExtract] Don't add autolink hint for frameworks. #65051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default system linkers on non-Darwin platforms do not support the `-framework` argument for framework linking. This change updates autolinking to not emit `-framework` into the .o _swift1_autolink_entries metadata when there is no native linker support. This is related to rdar://106578342.
|
Related PR for llvm: swiftlang/llvm-project#6502 |
|
@swift-ci please test |
|
Thanks for the review Artem. |
|
@swift-ci please test macOS platform |
|
@swift-ci Please test macOS platform |
1 similar comment
|
@swift-ci Please test macOS platform |
ributzka
added a commit
to ributzka/swift
that referenced
this pull request
Apr 14, 2023
…ftlang#65051) Default system linkers on non-Darwin platforms do not support the `-framework` argument for framework linking. This change updates autolinking to not emit `-framework` into the .o _swift1_autolink_entries metadata when there is no native linker support. This is related to rdar://106578342. (cherry picked from commit 17c5010)
ributzka
added a commit
that referenced
this pull request
Apr 14, 2023
) (#65184) Default system linkers on non-Darwin platforms do not support the `-framework` argument for framework linking. This change updates autolinking to not emit `-framework` into the .o _swift1_autolink_entries metadata when there is no native linker support. This is related to rdar://106578342. (cherry picked from commit 17c5010)
ributzka
added a commit
to ributzka/swift
that referenced
this pull request
Apr 17, 2023
Updates the code to also skip the framework autolink hint on Windows. Follow-up to swiftlang#65051. Related to rdar://108052357.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default system linkers on non-Darwin platforms do not support the
-frameworkargument for framework linking. This change updates autolinking to not emit-frameworkinto the .o _swift1_autolink_entries metadata when there is no native linker support.This is related to rdar://106578342.