[cxx-interop] Adding std.string initializer for UnsafePointer<CChar>?

[plotfi]

Currently without an initializer for the unsafe char pointer type swiftc hits an assert around not being able to handle conversions of unsafe pointers with Any type. This patch adds the ability to convert to a std::string.

This is to address issue #61218

[egorzhdan]

@swift-ci please smoke test

[egorzhdan]

Thanks @plotfi!
Could you please also add an execution test to make sure that the std::string that is created has the correct contents?
Otherwise LGTM.

[plotfi]

Thanks @plotfi!
Could you please also add an execution test to make sure that the std::string that is created has the correct contents?
Otherwise LGTM.

Hi @egorzhdan can you point me to some similar execution tests that are already in tree? I am a little lost, sorry.

[egorzhdan]

@plotfi sure! Just adding a new test to test/Interop/Cxx/stdlib/overlay/std-string-overlay.swift should work.
Something like:

StdStringOverlayTestSuite.test("std::string from C string") {
  let str = "abc".withCString { ptr in
    std.string(ptr)
  }
  expectEqual(str, std.string("abc"))
}

[plotfi]

@swift-ci please smoke test

[NuriAmari]

@swift-ci please smoke test

[plotfi]

@plotfi sure! Just adding a new test to test/Interop/Cxx/stdlib/overlay/std-string-overlay.swift should work. Something like:

StdStringOverlayTestSuite.test("std::string from C string") {
  let str = "abc".withCString { ptr in
    std.string(ptr)
  }
  expectEqual(str, std.string("abc"))
}

Thank You Egor! I will remember this in the future.

[hyp]

@plotfi this should also go to 5.9