[Backtracing] Security improvements. #65066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al45tair
force-pushed
the
eng/PR-107362003
branch
from
0afa0d7 to
31707bc
Compare
|
@swift-ci Please test |
mikeash
approved these changes
Apr 11, 2023
Use `task_read_for_pid()` rather than having the crashing program pass its own task port through. This opts us in to additional OS security measures surrounding the use of this call. rdar://107362003
al45tair
force-pushed
the
eng/PR-107362003
branch
from
31707bc to
e5680de
Compare
|
@swift-ci Please test |
Using the hardened runtime for tests doesn't work. rdar://107362003
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
For some reason it wants two blank lines instead of one here. rdar://107362003
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
task_read_for_pid()rather than having the crashing program pass its own task port through. This opts us in to additional OS security measures surrounding the use of this call.rdar://107362003