Fixes to utilities used by OSSALifetimeCompletion #65074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meg-gupta
force-pushed
the
completelifetimefixes
branch
from
dd00dea to
52cd817
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test macOS Platform |
1 similar comment
|
@swift-ci smoke test macOS Platform |
nate-chandler
approved these changes
Apr 12, 2023
lib/SIL/Utils/OwnershipUtils.cpp
Outdated
| @@ -751,6 +751,30 @@ BorrowedValue BorrowingOperand::getBorrowIntroducingUserResult() { | |||
| llvm_unreachable("covered switch"); | |||
| } | |||
|
|
|||
| SILValue BorrowingOperand::getIntroducingUserResult() { | |||
There was a problem hiding this comment.
Nit: Would getUserResult be good? (Or, what's being introduced?)
Looks like it was updated to getScopeIntroducingUserResult--thanks!
meg-gupta
force-pushed
the
completelifetimefixes
branch
from
52cd817 to
aea6ed2
Compare
|
@swift-ci please smoke test and merge |
…gOperand kinds Not all BorrowingOperand introduce a BorrowedValue. Add a new api to get the defining value for use in InteriorLivenessVisitor::handleInnerBorrow.
meg-gupta
force-pushed
the
completelifetimefixes
branch
from
aea6ed2 to
264d86d
Compare
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.