Skip to content

[interop] add availability for foreign reference types #65081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Apr 11, 2023

Such types have runtime support only in SwiftStdlib 5.8 and above

also,

Revert "[cxx-interop][SwiftCompilerSources] Use swift::DiagnosticEngine instead of BridgedDiagnosticEngine"

This reverts commit e9dedf3c270a454f278de298679fe82fbfe2521e.

The revert is required as foreign reference types are available for SwiftStdlib 5.8 and above, but the Swift compiler
sources back deploy to older stdlibs as well.

hyp and others added 2 commits April 11, 2023 15:28
…ine` instead of `BridgedDiagnosticEngine`"

This reverts commit e9dedf3.

The revert is required as foreign reference types are available for SwiftStdlib 5.8 and above, but the Swift compiler
sources back deploy to older stdlibs as well.
Such types have runtime support only SwiftStdlib 5.8 and above
@hyp
Copy link
Contributor Author

hyp commented Apr 11, 2023

@swift-ci please test

@hyp hyp requested a review from ravikandhadai April 11, 2023 22:29
@hyp
Copy link
Contributor Author

hyp commented Apr 11, 2023

@swift-ci please test source compatibility

@hyp hyp merged commit 4b3c51f into swiftlang:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants