[5.9] Add the drop_deinit instruction #65094
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
his instruction is a marker for a following destroy instruction to suppress the call of the move-only type's deinitializer.
…gument This happens for address-only move-only types.
…eeded by a drop_deinit rdar://105798769
eeckstein
force-pushed
the
drop-deinit-5.9
branch
from
33ed3d9 to
dbc9f74
Compare
|
@swift-ci test |
kavon
approved these changes
Apr 17, 2023
Comment on lines
+1225
to
+1228
| void visitDropDeinitInst(DropDeinitInst *i) { | ||
| auto e = getLoweredExplosion(i->getOperand()); | ||
| setLoweredExplosion(i, e); | ||
| } |
There was a problem hiding this comment.
If the instruction is only valid in OSSA, isn't this not necessary because reaching IRGen is unexpected / an error?
There was a problem hiding this comment.
True. This could be an unreachable.
I just copied from visitMoveValueInst.
But you are right, we should replace both visit functions with unreachable
| @@ -2385,7 +2385,7 @@ struct DeallocatorConventions : Conventions { | |||
|
|
|||
| ParameterConvention | |||
| getIndirectSelfParameter(const AbstractionPattern &type) const override { | |||
| llvm_unreachable("Deallocators do not have indirect self parameters"); | |||
| return ParameterConvention::Indirect_In; | |||
There was a problem hiding this comment.
I'm curious about why this change was needed.
There was a problem hiding this comment.
This is for supporting deinits which get the self argument as indirect argument, which is the case for move-only types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
drop_deinitinstruction is a marker for a following destroy instruction to suppress the call of the move-only type's deinitializer.SILGen needs to insert
drop_deinitin move-only deinitializers to avoid that - due to other optimizations, like inlining - the deinitializer call is inserted multiple times.rdar://105798769
This is a cherry-pick of #65060