Handle #if for if/switch expressions
#65098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this to replace `Parser::shouldReturnSingleExpressionElement`. This should be NFC.
Previously we would say that it must end with a `throw`, but a more useful diagnostic is that there is an expression missing.
- Allow an if/switch expression to become an implicit return of a function that has a `#if` body with a single active element that is an `if` or `switch`. - Allow `#if` branches of an if/switch expression, as long as there is a single active expression element. rdar://107487977
hamishknight
requested review from
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor and
rintaro
as code owners
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
xedin
approved these changes
Apr 12, 2023
ahoppen
approved these changes
Apr 12, 2023
|
Source compat failures match those on main. |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#ifbody with a single active element that is aniforswitch.#ifbranches of an if/switch expression, as long as there is a single active expression element.rdar://107487977