Skip to content

[TempRValueOpt] NFC: Clarified assertion. #65099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2023
Merged

[TempRValueOpt] NFC: Clarified assertion. #65099

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions lib/SILOptimizer/Transforms/TempRValueElimination.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,17 +616,23 @@ void TempRValueOptPass::tryOptimizeCopyIntoTemp(CopyAddrInst *copyInst) {
if (lastLoadInst == copyInst)
return true;
if (auto *cai = dyn_cast<CopyAddrInst>(lastLoadInst)) {
auto retval = cai->getSrc() != tempObj || !cai->isTakeOfSrc();
assert(!tempObj->getType().isMoveOnly() ||
!retval && "introducing copy of move-only value!?");
return retval;
if (cai->getSrc() == tempObj && cai->isTakeOfSrc()) {
// This copy_addr [take] will perform the final deinitialization.
return false;
}
assert(!tempObj->getType().isMoveOnly() &&
"introducing copy of move-only value!?");
return true;
}
if (auto *li = dyn_cast<LoadInst>(lastLoadInst)) {
auto retval = li->getOperand() != tempObj ||
li->getOwnershipQualifier() != LoadOwnershipQualifier::Take;
assert(!tempObj->getType().isMoveOnly() ||
!retval && "introducing copy of move-only value!?");
return retval;
if (li->getOperand() == tempObj &&
li->getOwnershipQualifier() == LoadOwnershipQualifier::Take) {
// This load [take] will perform the final deinitialization.
return false;
}
assert(!tempObj->getType().isMoveOnly() &&
"introducing copy of move-only value!?");
return true;
}
return true;
}();
Expand Down