Skip to content

Allow all unicode characters in package-name input #65111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2023
Merged

Allow all unicode characters in package-name input #65111

merged 1 commit into from
Apr 21, 2023

Conversation

elsh
Copy link
Contributor

@elsh elsh commented Apr 12, 2023 •
edited
Loading

  • Allow all unicode characters in package-name input string
  • Error if the input is empty
    Resolves rdar://104617274

artemcm
artemcm reviewed Apr 12, 2023
View reviewed changes
@artemcm
Copy link
Contributor

artemcm commented Apr 12, 2023

This change introduces a new ability to have certain flags get printed only in the swift-module-flags-ignorable field of the private interface file. Which is a significant addition - could you please make the commit message and the PR title reflect that?

artemcm
artemcm reviewed Apr 12, 2023
View reviewed changes
@elsh elsh force-pushed the es-str branch 2 times, most recently from 69a2510 to 1a6ac90 Compare April 12, 2023 23:01
@elsh
Copy link
Contributor Author

elsh commented Apr 12, 2023

@swift-ci smoke test

@elsh elsh changed the title Use quoted string for package name input Introduce an option to only print flags in a private interface Apr 12, 2023
@elsh elsh force-pushed the es-str branch 3 times, most recently from 4cac784 to 338d3a5 Compare April 13, 2023 00:52
artemcm
artemcm approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@elsh
Copy link
Contributor Author

elsh commented Apr 14, 2023

@swift-ci smoke test

@elsh
Copy link
Contributor Author

elsh commented Apr 18, 2023

@swift-ci smoke test

@elsh
Copy link
Contributor Author

elsh commented Apr 20, 2023

@swift-ci smoke test

@elsh elsh changed the title Introduce an option to only print flags in a private interface Allow all unicode characters in package-name input Apr 20, 2023
@elsh
Copy link
Contributor Author

elsh commented Apr 20, 2023

@swift-ci smoke test

@elsh
Copy link
Contributor Author

elsh commented Apr 20, 2023 •
edited
Loading

This change introduces a new ability to have certain flags get printed only in the swift-module-flags-ignorable field of the private interface file. Which is a significant addition - could you please make the commit message and the PR title reflect that?

The private interface related portion of this PR is split into a separate PR as more changes were needed; will add you to that PR for further review. This PR now just allows unicode characters in the package-name input.

@elsh
Copy link
Contributor Author

elsh commented Apr 20, 2023

@swift-ci smoke test

@elsh
Allow all unicode characters in package-name input
3a4cd36 
Error if the input is empty
Resolves rdar://104617274
@elsh
Copy link
Contributor Author

elsh commented Apr 20, 2023

@swift-ci smoke test windows

@elsh
Copy link
Contributor Author

elsh commented Apr 20, 2023

@swift-ci smoke test linux

@elsh
Copy link
Contributor Author

elsh commented Apr 20, 2023

@swift-ci smoke test macOS

@elsh elsh merged commit 578c63a into main Apr 21, 2023
@elsh elsh deleted the es-str branch April 21, 2023 00:13
@elsh elsh mentioned this pull request Apr 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemcm artemcm artemcm approved these changes

@hborla hborla Awaiting requested review from hborla

@slavapestov slavapestov Awaiting requested review from slavapestov

@xedin xedin Awaiting requested review from xedin

@tshortli tshortli Awaiting requested review from tshortli tshortli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elsh @artemcm