Simple SILOptimizer peepholes for packs #65119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
sil-optimizer-peepholes-for-packs
branch
from
eac722e to
e7eb7c3
Compare
slavapestov
force-pushed
the
sil-optimizer-peepholes-for-packs
branch
from
e7eb7c3 to
0896540
Compare
|
@swift-ci Please smoke test |
slavapestov
force-pushed
the
sil-optimizer-peepholes-for-packs
branch
from
18fd58d to
fa28d14
Compare
|
@swift-ci Please smoke test |
|
@slavapestov Sorry I missed this PR. Just one comment: Note that it's now possible to implement SILCombine peepholes in swift. Example: https://github.com/apple/swift/blob/main/SwiftCompilerSources/Sources/Optimizer/InstructionSimplification/SimplifyStrongRetainRelease.swift |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to inline away
(repeat each t)for forming a tuple value from the elements of a value pack in the case where the pack becomes concrete. We're not quite there yet; there are still some unnecessary pack-related SIL instructions remaining.