Skip to content

[interop] Prohibit use of C++ APIs in public interfaces that opt-in i… #65129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Apr 13, 2023

…nto library evolution

The CxxStdlib overlay now has to be built without library evolution enabled.

@hyp hyp added the c++ interop Feature: Interoperability with C++ label Apr 13, 2023
@hyp hyp requested review from ravikandhadai and removed request for xedin, slavapestov and hborla April 13, 2023 03:22
@hyp hyp force-pushed the eng/no-evo-cxx branch from 5877aea to 003a49d Compare April 13, 2023 03:29
@hyp
Copy link
Contributor Author

hyp commented Apr 13, 2023

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Apr 13, 2023

@swift-ci please test source compatibility

…nto library evolution

The CxxStdlib overlay now has to be built without library evolution enabled.
@hyp hyp force-pushed the eng/no-evo-cxx branch from 003a49d to 045fcf3 Compare April 13, 2023 17:48
@hyp
Copy link
Contributor Author

hyp commented Apr 13, 2023

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Apr 13, 2023

@swift-ci please test source compatibility

return false;
}
}
// An Objective-C property whose can be compatible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo: whose -> whose type

@hyp
Copy link
Contributor Author

hyp commented Jul 14, 2023

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Jul 15, 2023

@swift-ci please test source compatibility

2 similar comments
@hyp
Copy link
Contributor Author

hyp commented Jul 17, 2023

@swift-ci please test source compatibility

@hyp
Copy link
Contributor Author

hyp commented Jul 18, 2023

@swift-ci please test source compatibility

@hyp
Copy link
Contributor Author

hyp commented Jul 19, 2023

source compat failures are unrelated.

@hyp hyp merged commit 3748b0f into swiftlang:main Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants