[5.9][move-only] Make it an error if we attempt to destructure/partially invalidate through a field with a deinit. #65131
+851
−362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvalidate through a field with a deinit. If one has a type with a deinit, if one were to partially invalidate the value, the checker will clean up the remaining parts of the value but not the actual underlying value. This then would cause the deinit of the actual type to be called. rdar://101651138 (cherry picked from commit 76e9382)
|
@swift-ci test |
gottesmm
changed the title
jckarter
reviewed
Apr 13, 2023
| // cannot contain non-copyable types and that our parent root type must be | ||
| // an enum, tuple, or struct. | ||
| if (auto *nom = iterType.getNominalOrBoundGenericNominal()) { | ||
| if (mod.lookUpMoveOnlyDeinitFunction(nom)) { |
There was a problem hiding this comment.
Would it be better to check nom->getValueTypeDestructor(), in case the type is from another module and the SIL-level deinit wasn't deserialized?
There was a problem hiding this comment.
@jckarter I can change that in a follow on commit. I'll also add a note saying deinit declared here.
jckarter
approved these changes
Apr 13, 2023
tbkka
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one has a type with a deinit, if one were to partially invalidate the value, the checker will clean up the remaining parts of the value but not the actual underlying value. This then would cause the deinit of the actual type to not be called.
rdar://101651138
(cherry picked from commit 76e9382)
Explanation: If one has a type with a deinit, if one were to partially invalidate the value, the checker will clean up the remaining parts of the value but not the actual underlying value. This then would cause the deinit of the actual type to not be called.
Scope: Only affects noncopyable types since it only changes the move only checkers.
Risk: Low.
Testing: Added compiler tests