Skip to content

[5.9 🍒] TypeCheckType: Fix existential any migration diagnostics for extra-modular protocols #65146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 27, 2023
Merged

[5.9 🍒] TypeCheckType: Fix existential any migration diagnostics for extra-modular protocols #65146

merged 2 commits into from
Apr 27, 2023

Conversation

AnthonyLatsis
Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis commented Apr 13, 2023 •
edited
Loading

@AnthonyLatsis
TypeCheckType: Fix existential 'any' migration diagnostics for extra-…
d90969a 
…modular protocols
@AnthonyLatsis
[NFC] ExistentialRequiresAnyRequest → HasSelfOrAssociatedTypeRequirem…
f0d5990 
…entsRequest

The current name is misleading because it suggests that the request accounts
for language feature state, which it does not (and is not supposed to).
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.9 labels Apr 13, 2023
@AnthonyLatsis AnthonyLatsis requested a review from a team as a code owner April 13, 2023 16:05
@AnthonyLatsis AnthonyLatsis requested a review from hborla April 13, 2023 16:06
@AnthonyLatsis AnthonyLatsis linked an issue Apr 13, 2023 that may be closed by this pull request
Enabling upcoming feature ExistentialAny does not work for standard library protocols. #65034
Closed
@AnthonyLatsis AnthonyLatsis added compiler The Swift compiler itself diagnostics QoI Bug: Diagnostics Quality of Implementation type checker Area → compiler: Semantic analysis existentials Feature: values of types like `any Collection`, `Any` and `AnyObject`; type-erased values labels Apr 13, 2023
@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please test

@AnthonyLatsis AnthonyLatsis added the bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. label Apr 21, 2023
@AnthonyLatsis
Copy link
Collaborator Author

@hborla ping

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please test

@AnthonyLatsis
Copy link
Collaborator Author

I’m wondering if we can set up our CI↔︎GitHub infra to require rerunning successful checks after a period of time.

@AnthonyLatsis AnthonyLatsis merged commit 6b6b8da into swiftlang:release/5.9 Apr 27, 2023
@AnthonyLatsis AnthonyLatsis deleted the existential-any-multimodule-5.9 branch April 27, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla hborla approved these changes

Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler itself diagnostics QoI Bug: Diagnostics Quality of Implementation existentials Feature: values of types like `any Collection`, `Any` and `AnyObject`; type-erased values 🍒 release cherry pick Flag: Release branch cherry picks swift 5.9 type checker Area → compiler: Semantic analysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enabling upcoming feature ExistentialAny does not work for standard library protocols.
2 participants
@AnthonyLatsis @hborla