Skip to content

[5.8 🍒] TypeCheckType: Fix existential any migration diagnostics for extra-modular protocols #65160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[5.8 🍒] TypeCheckType: Fix existential any migration diagnostics for extra-modular protocols #65160

wants to merge 2 commits into from

Conversation

AnthonyLatsis
Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis commented Apr 13, 2023 •
edited
Loading

I’m attempting to bring this fix to 5.8 because the issue negatively affects piecemeal adoption of existential any syntax (--enable-upcoming-feature ExistentialAny) — a Swift 6 feature with substantial source impact — in that the syntax is not enforced on standard library existentials such as Error and Codable. More generally, any existential that has a native imported constraint type and is normally allowed to omit any in Swift 5.

@AnthonyLatsis
TypeCheckType: Fix existential 'any' migration diagnostics for extra-…
01948a4 
…modular protocols
@AnthonyLatsis
[NFC] ExistentialRequiresAnyRequest → HasSelfOrAssociatedTypeRequirem…
07e7f42 
…entsRequest

The current name is misleading because it suggests that the request accounts
for language feature state, which it does not (and is not supposed to).
@AnthonyLatsis AnthonyLatsis requested a review from a team as a code owner April 13, 2023 20:43
@AnthonyLatsis AnthonyLatsis added compiler The Swift compiler itself diagnostics QoI Bug: Diagnostics Quality of Implementation type checker Area → compiler: Semantic analysis existentials Feature: values of types like `any Collection`, `Any` and `AnyObject`; type-erased values 🍒 release cherry pick Flag: Release branch cherry picks swift 5.8 labels Apr 13, 2023
@AnthonyLatsis AnthonyLatsis linked an issue Apr 13, 2023 that may be closed by this pull request
Enabling upcoming feature ExistentialAny does not work for standard library protocols. #65034
Closed
@AnthonyLatsis AnthonyLatsis added the bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. label Apr 21, 2023
@hborla
Copy link
Member

hborla commented Jul 21, 2023

Unfortunately, we can't take general type checker bug fixes anymore for the 5.8 branch.

@hborla hborla closed this Jul 21, 2023
@AnthonyLatsis AnthonyLatsis deleted the existential-any-multimodule-5.8 branch July 22, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler itself diagnostics QoI Bug: Diagnostics Quality of Implementation existentials Feature: values of types like `any Collection`, `Any` and `AnyObject`; type-erased values 🍒 release cherry pick Flag: Release branch cherry picks type checker Area → compiler: Semantic analysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enabling upcoming feature ExistentialAny does not work for standard library protocols.
2 participants
@AnthonyLatsis @hborla