[IRGen] Fix layout string generation for pre-specialized metadata #65162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
|
@aschwaighofer I have so far been unable to reproduce the issue in a test. |
| @@ -2833,7 +2833,10 @@ void swift::swift_initStructMetadataWithLayoutString( | |||
| previousFieldOffset = fieldType->vw_size(); | |||
| fullOffset += previousFieldOffset; | |||
| } else if (fieldType->isAnyExistentialType()) { | |||
| auto tag = RefCountingKind::Existential; | |||
| auto *existential = dyn_cast<ExistentialTypeMetadata>(fieldType); | |||
rdar://108012057 Pre-specialized metadata has to be specifically handled by using the bound generic type instead of the unbound one. All the necessary information is already being passed down as BoundGenericTypeCharacteristics, we just need to apply them when present.
|
@swift-ci smoke test |
|
@swift-ci smoke test |
drexin
added a commit
to drexin/swift
that referenced
this pull request
Apr 20, 2023
…iftlang#65162) * [IRGen] Fix layout string generation for pre-specialized metadata rdar://108012057 Pre-specialized metadata has to be specifically handled by using the bound generic type instead of the unbound one. All the necessary information is already being passed down as BoundGenericTypeCharacteristics, we just need to apply them when present. * Add tests and a few fixes * Fixes after rebase * Attempt to fix Windows linker issue in test
drexin
added a commit
that referenced
this pull request
Apr 21, 2023
…5162) (#65327) * [IRGen] Fix layout string generation for pre-specialized metadata rdar://108012057 Pre-specialized metadata has to be specifically handled by using the bound generic type instead of the unbound one. All the necessary information is already being passed down as BoundGenericTypeCharacteristics, we just need to apply them when present. * Add tests and a few fixes * Fixes after rebase * Attempt to fix Windows linker issue in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://108012057
Pre-specialized metadata has to be specifically handled by using the bound generic type instead of the unbound one. All the necessary information is already being passed down as BoundGenericTypeCharacteristics, we just need to apply them when present.