[5.9][IRGen] Use ConditionalDominanceScope in AbstractMetadataAccessor::em… #65163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it (swiftlang#64585) * [IRGen] Use ConditionalDominanceScope in AbstractMetadataAccessor::emit rdar://103179745 Under certain conditions the missing dominance scope caused a cached witness table ref to be used in a block that it was not available in. * Fix target in test
|
@swift-ci test |
|
@tbkka The PR to main was reviewed and approved by @aschwaighofer. Would you mind approving this? |
drexin
changed the title
tbkka
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…it (#64585)
Cherry-picked from: #64585
rdar://103179745
Under certain conditions the missing dominance scope caused a cached witness table ref to be used in a block that it was not available in.