[IDE] Inject Sendable conformance on public types only in getTopLevelDeclsForDisplay
#65168
Conversation
|
@swift-ci Please smoke test |
test/IDE/print_stdlib.swift
Outdated
| @@ -55,6 +55,8 @@ | |||
| // NO-FIXMES-NOT: FIXME | |||
| // RUN: %target-swift-ide-test -print-module-groups -module-to-print=Swift -source-filename %s -print-interface > %t-group.txt | |||
| // RUN: %FileCheck -check-prefix=CHECK-GROUPS1 %s < %t-group.txt | |||
| // RUN: %target-swift-ide-test -print-module-groups -module-to-print=Swift -source-filename %s -print-interface -enable-deserialization-safety > %t-group.txt | |||
There was a problem hiding this comment.
I assume this was crashing before with deserialization safety enabled? I wonder if we could craft an example that doesn't need it? Maybe not worth it though.
It just seems a little weird to have on this particular test, since it's somewhat surprising that enabling deserialization safety would have any impact here when we're just printing groups.
There was a problem hiding this comment.
Right, it crashed with deserialization safety enabled. Both -print-module-groups and -print-module call getTopLevelDeclsForDisplay, it looks like with the groups we also print the top-level decls in the group.
The failing scenario doesn't appear that complicated to reproduce but I didn't manage to write a reduced test case that triggers the crash. They're likely something to trigger in the requirement machine logic that I'm missing. Instead I've added a comment to the test.
@swift-ci Please smoke test macOS |
When getTopLevelDeclsForDisplay is called on an imported module, it may lists non-public decls. If we they try to inject the conformance on Sendable on internal types, the compiler may crash on failing to deserialize internal details. As a fix, let's only inject the conformance on public or package types. rdar://95430471
xymus
force-pushed
the
display-public-only
branch
from
3a11a52 to
7f32a9e
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Windows |
When
getTopLevelDeclsForDisplayis called on an imported module, it may lists non-public decls. If we they try to inject the conformance on Sendable on internal types the compiler may crash on failing to deserialize internal details. Let's only inject the conformance on public or package types to avoid this.In the future we may want to make
getTopLevelDeclsForDisplayreturn only public and package types and no internal details at all.rdar://95430471