[SILSymbolVisitor] Skip internal nominal type decls #65175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SILSymbolVisitor` crashes with deserialization failures with opaque type in internal modules when adding conformances to public protocols. Resolves rdar://107672461
|
Actually this is superseded by #64991 where the deserialization was fixed. The test failed earlier without the |
|
Yep. #64991 fixed it 🎉 |
|
Re-opening for planning reasons |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
|
@zixu-w Do you plan on merging this? I think it's still a worthwhile change on its own even if we avoided last crash in a different way. |
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SILSymbolVisitorcrashes with deserialization failures with opaque type in internal modules when adding conformances to public protocols.Resolves rdar://107672461