[5.9][CodeCompletion] Don't take opaque types subst map into account #65176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for checking duplicated results from multiple type checker solutions.
e.g.
protocol Proto {}
struct Generic<T> {
func retProto() -> some Proto
}
func foo() -> Generic<T1>
func foo() -> Generic<T2>
foo().<COMPLETION>
The return type of `Geric<T1>.retProto()` and `Geric<T2>.retProto()` is
different, but they both spelled 'some Proto'. So IDE consumers don't
care the difference.
rdar://107669173
(cherry picked from commit 20a8441)
|
@swift-ci Please test |
airspeedswift
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #65170 into
release/5.9Explanation: When a completion base type has multiple possible solutions, member lookup for code completion is performed on both types, then duplicated (decl and the type are the same) results are omitted. However, for opaque types, it used to fail to deduplicate them because they have different substitution map, although both have the same spelling. In this change, replace the opaque types substitution map with an empty one, so that it ignore the map when comparing.
Scope: Code completion related to opaque result type.
Risk: Low, the change only affects de-duplication
Testing: Added a regression test case
Issue: rdar://107669173
Reviewer: Ben Barham (@bnbarham), Alex Hoppen (@ahoppen)