[5.9] Batched cherry-picks #65195
Merged
[5.9] Batched cherry-picks #65195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://104395115 (cherry picked from commit 94fb5ce)
…n instance to make sure it is initialized. I ran into this while fixing the parent commit when attempting to add the interpreter test in this commit into the aforementioned parent commit. rdar://107974302 (cherry picked from commit 19f1ded)
… deinit at the AST level rather than the SIL level. I also added a note telling the user where the deinit is. rdar://101651138 (cherry picked from commit 8118240)
|
@swift-ci test |
jckarter
approved these changes
Apr 14, 2023
tbkka
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just batching some cherry-picks in order to lower the amount of times I need to ping the branch managers.
This PR contains the following changes:
Explanation: This changes the noncopyable types implementation in two ways: 1. It adds support for handling structs without any fields to the move checker. This was done by just saying that they artificially have a single field rather than no fields. 2. It changes the implementation around validating that we do not partially invalidate types with deinits to use AST information instead of SIL level information. I also used this as an opportunity to insert a new note on the deinit itself that is causing the error so it shows up in the IDE.
Scope: Only affects noncopyable types since it only changes the move only checkers.
Risk: Low.
Testing: Added compiler tests