Skip to content

[Macros] Break reference cycles involving visible name lookup #65221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2023
Merged

[Macros] Break reference cycles involving visible name lookup #65221

merged 1 commit into from
Apr 17, 2023

Conversation

DougGregor
Copy link
Member

@DougGregor DougGregor commented Apr 17, 2023 •
edited
Loading

  • Explanation: Lookup of all visible declarations, which occurs primarily in invalid code, could trigger request cycles due to macro expansion. Break those reference cycles.
  • Scope: Impacts new, invalid code using macro expansion .
  • Risk: Low.
  • Testing: Extend existing tests.
  • Main branch PR: [Macros] Break reference cycles involving visible name lookup #65219

@DougGregor DougGregor requested a review from a team as a code owner April 17, 2023 03:23
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor DougGregor merged commit d258ed7 into swiftlang:release/5.9 Apr 17, 2023
@DougGregor DougGregor deleted the reference-cycle-visible-name-lookup-5.9 branch April 17, 2023 12:06
@AnthonyLatsis AnthonyLatsis added the 🍒 release cherry pick Flag: Release branch cherry picks label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla hborla approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DougGregor @hborla @AnthonyLatsis