[Parser] Make parser aware of the unexpected attributes in operator declarations #65224
Conversation
lib/Parse/ParseDecl.cpp
Outdated
| continue; | ||
| } | ||
| auto *attr = *it; | ||
| P.diagnose(attr->getLocation(), diag::operator_decl_should_not_contain_other_attributes, attr->getAttrName()); |
There was a problem hiding this comment.
Could you add a Fix-It to this diagnostic to remove the attribute (similar to line 4599).
Could you format the line to only contain 80 columns? I usually run git-clang-format, which (IIRC) you can install using Homebrew.
test/Parse/operator_decl.swift
Outdated
| @@ -117,3 +117,5 @@ infix operator *<*< : F, Proto | |||
|
|
|||
| // expected-error@+2 {{expected precedence group name after ':' in operator declaration}} | |||
| postfix operator ++: // expected-error {{only infix operators may declare a precedence}} {{20-21=}} | |||
|
|
|||
| dynamic prefix operator +!+ // expected-error{{unexpected attribute 'dynamic' in operator declaration}} | |||
There was a problem hiding this comment.
I see that you moved this test case. Could you keep the assertion that there should be a Fix-It to remove dynamic, i.e. the `{{1-9=}} part?
Could you add a newline at the end of the file?
StevenWong12
force-pushed
the
diagnositic_on_modifiers_in_operatordecl
branch
from
916ae38 to
19dd7fd
Compare
|
@swift-ci Please smoke test |
|
Hey @ahoppen, sorry for the late reply. I've modified my codes according to your suggestions. When I rebuild the stdlib locally, I got some errors as follows It seems that some files used to build the stdlib use the |
StevenWong12
requested review from
bnbarham,
CodaFi,
DougGregor,
rintaro,
hborla,
slavapestov and
xedin
as code owners
|
I’m not 100% sure what’s going wrong here but my bet right now is that you will be able to reproduce the issue with /// some doc comment
prefix operator +!+ The compiler models doc comments as attributes and you are marking them as invalid. So, you should also be allowing doc comments (with attribute kind |
StevenWong12
force-pushed
the
diagnositic_on_modifiers_in_operatordecl
branch
from
19dd7fd to
3cabe08
Compare
|
I've added doc comments as an allowable attribute in operator declaration and the stdlib can be successfully built now.
But I still can not reproduce this problem locally. It's kind of weird. |
|
Let’s see what CI has to say about it. @swift-ci Please smoke test |
|
Sorry, I forgot about this PR after I triggered CI. Merged now. |
To sync the changes in swiftlang/swift-syntax#1448 (review)