SIL Optimizer improvements for variadic generics [5.9] #65241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
slavapestov
commented
Apr 18, 2023
slavapestov
commented
- Description: Improves quality of optimized code when calling a variadic generic function with a concrete pack type, by eliminating the iteration over the pack and in trivial cases, the element archetype. Also, fixes SIL serialization for @inlinable/@_alwaysEmitIntoClient variadic functions.
- Risk: Low, should at worst break variadic generics.
- Tested: New tests added.
- Reviewed by @hborla
- Radar: rdar://108004074
…tuple_pack_element_addr
…hout overflow checks
hborla
approved these changes
Apr 18, 2023
|
@swift-ci Please test |
slavapestov
force-pushed
the
sil-optimizer-variadic-generics-5.9
branch
from
5599ef4 to
c8ef00f
Compare
|
@swift-ci Please test |
Fixes rdar://problem/108045677.
…c generic instructions Fixes rdar://108004074.
slavapestov
force-pushed
the
sil-optimizer-variadic-generics-5.9
branch
from
c8ef00f to
b215d61
Compare
|
@swift-ci Please test |
|
@swift-ci Please test MacOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.