Skip to content

[cxx-interop] Enable CxxShim headers for armv7k watchOS #65259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

egorzhdan
Copy link
Contributor

This fixes the no such module 'CxxStdlibShim' error when building CxxStdlib for armv7k.

For watchOS, armv7k is included in ${SWIFT_SDK_${sdk}_MODULE_ARCHITECTURES} but not in ${SWIFT_SDK_${sdk}_ARCHITECTURES}.

rdar://108206099

This fixes the `no such module 'CxxStdlibShim'` error when building CxxStdlib for armv7k.

For watchOS, armv7k is included in `${SWIFT_SDK_${sdk}_MODULE_ARCHITECTURES}` but not in `${SWIFT_SDK_${sdk}_ARCHITECTURES}`.

rdar://108206099
@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Apr 18, 2023
@egorzhdan egorzhdan requested review from zoecarver and hyp as code owners April 18, 2023 17:08
@egorzhdan egorzhdan requested a review from edymtt April 18, 2023 17:09
@egorzhdan
Copy link
Contributor Author

Thanks @edymtt for discovering this!

@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan merged commit 31361f8 into main Apr 18, 2023
@egorzhdan egorzhdan deleted the egorzhdan/cxxstdlib-armv7k branch April 18, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants