[5.9] Handle async vs. completion-handler mismatches in @_objcImplementation
#65260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@_objcImplementation
extension against an Objective-C method imported asasync
, we were not accounting for the fact that such methods can be imported both as bothasync
and with a completion handler, and therefore complained that one of the two Objective-C method signatures was not satisfied. Allow both of those requirements to be satisfied by a single candidate, whether it's of theasync
or completion-handler form.@_objcImplementation
feature with Objective-C methods that are imported asasync
.@_objcImplementation
. #65253