Skip to content

[5.9] Handle async vs. completion-handler mismatches in @_objcImplementation #65260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DougGregor
Copy link
Member

  • Explanation: When matching methods in an @_objcImplementation extension against an Objective-C method imported as async, we were not accounting for the fact that such methods can be imported both as both async and with a completion handler, and therefore complained that one of the two Objective-C method signatures was not satisfied. Allow both of those requirements to be satisfied by a single candidate, whether it's of the async or completion-handler form.
  • Scope: Affects code using the experimental @_objcImplementation feature with Objective-C methods that are imported as async.
  • Risk: Low, due to narrow scope and this loosening checking for certain methods.
  • Issue: rdar://108160837
  • Testing: Additional tests added.
  • Original pull request: Handle async vs. completion-handler mismatches in @_objcImplementation. #65253

@DougGregor DougGregor requested a review from a team as a code owner April 18, 2023 18:10
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor DougGregor merged commit 2257d65 into swiftlang:release/5.9 Apr 18, 2023
@DougGregor DougGregor deleted the objc-impl-async-completion-handler-matching-5.9 branch April 18, 2023 22:39
@AnthonyLatsis AnthonyLatsis added the 🍒 release cherry pick Flag: Release branch cherry picks label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants